Add GitHub Actions Cloud Run deploy path - #111
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c9ea35de7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| RUN python -m pip install --upgrade pip \ | ||
| && python -m pip install -r requirements.txt | ||
|
|
||
| COPY . . |
There was a problem hiding this comment.
When ENABLE_GITHUB_CLOUD_RUN_DEPLOY=true, the workflow authenticates with google-github-actions/auth before docker build, and that action creates gha-creds-*.json in $GITHUB_WORKSPACE by default; with no .dockerignore, COPY . . bakes that temporary GCP credential file (and the checked-out .git metadata) into the pushed Cloud Run image. Add a .dockerignore for gha-creds-*.json, .git/, etc. or build before creating the credentials file.
Useful? React with 👍 / 👎.
| --memory=512Mi \ | ||
| --cpu=1 \ | ||
| --timeout=300s \ | ||
| --labels="managed-by=github-actions,commit-sha=${GITHUB_SHA},github-run-id=${GITHUB_RUN_ID}" \ |
There was a problem hiding this comment.
In the deploy+env-sync path, the later wait loop reads spec.template.metadata.labels.commit-sha, but this deploy only passes --labels, which Cloud Run documents as service metadata.labels rather than revision-template spec.template.metadata.labels. With both ENABLE_GITHUB_CLOUD_RUN_DEPLOY=true and ENABLE_GITHUB_ENV_SYNC=true, the image deploy can succeed but the wait step never observes the SHA and times out before syncing env vars.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
Rollout